Do Repeat Yourself #
One of the first software development principles programmers learn is the DRY principle: Don’t Repeat Yourself. One can think of it as being quite self-explanatory, without requiring to go beyond “remove duplication” to claim understanding of it. Is that enough, though? What is duplication, anyway?
Let’s start from the beginning. Andrew Hunt and David Thomas first introduced this principle in their 1999 The Pragmatic Programmer: From Journeyman to Master book (an updated 20th Anniversary Edition is also available). A must-read, if you ask me. It states the following:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
This tip, number 11, is given amidst a section named The Evils of Duplication, where the authors explain the dangers of having duplicated knowledge within a system. The DRY principle is not as much about code as it is about knowledge. Any kind of knowledge, but especially domain knowledge. Sure, this knowledge will eventually become code. But the point is that there should be only one representation of it in code.
The Confusion #
It’s very easy for us, developers, especially beginners and expert-beginners, to misinterpret and obsess over it. We can go hours removing every bit of duplicated code, applying all the design patterns we know, thinking how smart we are, until there is not a single duplicated word left. This is very dangerous! In fact, we should be extra careful when refactoring to abstractions. Sandi Metz, in The Wrong Abstraction, summarizes very clearly saying that “duplication is far cheaper than the wrong abstraction”, so “prefer duplication over the wrong abstraction”.
At the same time, Robert C. Martin (“Uncle Bob”), in his well-known Clean Code book, emphasizes the idea that “duplication is the primary enemy of a well-designed system”. And so do a lot of other influential programmers, like Kent Beck and Ron Jeffries. So what gives?
Turns out that there’s one important fact we have to be aware of: there are different kinds of duplication. Uncle Bob touches on this very point in his most recent book Clean Architecture. There is true duplication, where the duplicates require the exact same changes, at the same times, for the same reasons – this is the kind we should cast away from our codebases. And there is false, or accidental duplication. This kind of duplication, we better let them be and just observe from afar.
How do we know which kind of duplication are we looking at, then? Years before publishing the Clean Architecture book, Bob hinted on this subject when he wrote “An Accidental Doppelgänger in Ruby", in 2009. In this post, he poses the question:
(…) if the implementation of two functions is identical, yet their intent is completely different, is it still duplicate code?
His conclusion, in this specific case, was: yes. The solution arose from paying good attention to the intent and the levels of abstraction of the code he was dealing with. Being able to immediately recognize when you are going up and down in the abstractions in a single method is a powerful skill to develop. It helps you identify missing abstractions and domain concepts earlier in the case of true duplication. As for accidental, or coincidental, duplication, understanding the real intent and purpose of the code is fundamental. It goes hand in hand with the Single Responsibility Principle, from the SOLID principles presented by Uncle Bob himself in Agile Software Development, Principles, Patterns, and Practices. So, asking questions like…
- How often would this piece of software change compared to the other?
- What are the reasons for changing one or the other?
- Who’d request such changes? The design team, the finances team?
- What purpose does this code serve?
- Which part of the architecture does it belong?
… can help identify, or prevent accidental duplicates.
It can be very tempting to pass along and use the same model or data structure across different architectural boundaries because they look the same at this point in time. As an example, the persistence and the presentation models can look the same in the very beginning of a project. This is an accidental duplication. It is only a coincidence that, at this very moment, they look exactly the same. Give them a few weeks and you’ll see them evolve along different paths.
If you find yourself writing “just another if-else clause”, it is very likely that you’re dealing with a bad abstraction. It’s like trying to push a square peg into a round hole. You may be able to squeeze an edge or two in, but it is wasted effort. Once you realize that, you are better off backing up and choosing a different peg. Sandi Metz, in the aforementioned blog post, explains how we usually end up in these situations and how to recover from them, acknowledging the sunk cost fallacy.
One piece of advice that it is worth following is “The Rule of Three”. Made popular by Martin Fowler in Refactoring: Improving the Design of Existing Code, and attributed to Don Roberts. It goes like this:
The first time you do something, you just do it. The second time you do something similar, you wince at the duplication, but you do the duplicate thing anyway. The third time you do something similar, you refactor.
Before DRY’ing up your code and refactoring it into abstractions, make sure you’re facing a real duplication. If you’re unsure, don’t be hasty. Observe it for some time. Following The Rule of Three, asking similar the questions to the ones presented earlier and talking to your colleagues about this subject can vastly improve your software design skills and the maintainability of your codebase.
Use the acronyms and catchphrases as reminders of certain principles or rules of thumb. But make sure you actually understand what lies behind those phrases. Remember to always take the extra step in learning a given subject.